[Webkit-unassigned] [Bug 38992] REGRESSION: Crash by pasting to a textarea with white-space:nowrap

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38992


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55952|review?                     |review+
               Flag|                            |




--- Comment #4 from Darin Adler <darin at apple.com>  2010-05-13 13:11:58 PST ---
(From update of attachment 55952)
Not new to this patch: It's very strange that this code specifically special-cases <div> elements. There's nothing unqiue about a <div> elements, is there? Can't a <p> elements perform almost the identical function?

The check that an element has a grandparent seems to be a roundabout way to define a "root node" that depends on the one hand on the fact that we use document fragments with single nodes in them and on the other hand on the fact that a document has an HTML element in it. I'd think that in the case of a document we'd not want to add a sibling to a body node either, so I think the parent->parent check is not ideal.

But r=me on this change for now, since it does some good and no harm.

I'd like further thought and testing, though, since this seems a little loose.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.