[Webkit-unassigned] [Bug 38711] DragData::asURL() shouldn't do file validity checks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38711


Jian Li <jianli at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55903|review?                     |review-
               Flag|                            |




--- Comment #13 from Jian Li <jianli at chromium.org>  2010-05-13 10:58:16 PST ---
(From update of attachment 55903)
Please also ask someone who is familiar with WebNSPasteboardExtras.mm to take a look.

LayoutTests/ChangeLog:3
 +          DragData::asURL() shouldn't do file validity checks
Since you also touch WebNSPasteboardExtras.mm, could you please update the bug title and all ChangeLog to describe the problem in generic way?

LayoutTests/editing/pasteboard/file-input-files-access.html: 
 +  <script src="../../fast/js/resources/js-test-post.js"></script>
Why do we need to remove this?

LayoutTests/editing/pasteboard/script-tests/file-input-files-access.js:112
 +      // It'd be easiest to use try-finally, but it doesn't work.
This comment is somewhat confusing. Can you explain?

LayoutTests/editing/pasteboard/script-tests/file-input-files-access.js:115
 +          // file input here.
Don't need to fold into 2 lines.

WebKit/mac/Misc/WebNSPasteboardExtras.mm:150
 +                  isDirectory)
Don't need to fold into 2 lines.

WebKit/mac/ChangeLog:11
 +          handling, since the Mac loader doesn't work correctly with them. 
I think there is a risk condition here. If the directory does not exist at first, [NSPasteboard _web_bestURL] will return a file URL. Then the directory is created.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.