[Webkit-unassigned] [Bug 37945] CMake buildsystem

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37945





--- Comment #27 from Adam Treat <treat at kde.org>  2010-05-13 08:43:36 PST ---
(In reply to comment #26)
> (In reply to comment #25)
> > (In reply to comment #24)
> > > (In reply to comment #23)
> > > > The port specific files should decide which unicode to include, etc.  Suggestions for mechanism for doing this would be helpful.  For instance, instead of the main CMakeLists.txt including Options{$PORT}... I'd rather it the other way around.  I'd rather the port specific build files including the cross-platform ones.
> > > I think the corss-platform one should include the platform-specific, because the ADD_SUBDIRECTORY() won't work otherwise.
> > > I don't like the INCLUDE("${PORT}"), but it might be the best solution in the moment. :-/
> > 
> > Why would we lose 'ADD_SUBDIRECTORY'... rather we'd have a top-level CMakeListsPORT.cmake file that includes the top-level cross-platform one and this could still do ADD_SUBDIRECTORY, no?
> Usualy ADD_SUBDIRECTORY uses CMakeLists.txt in the directory. Then you already have an cross-platfrom file. Why create a second one?
> I think you should have only a CMakeLists.txt, sometimes a DerivedSources.cmake and a PortXXX.cmake for each port.

Alright, but the cross-platform ones should be limited to including the port specific files... all other port specific logic should be removed from the cross-platform ones IMO.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.