[Webkit-unassigned] [Bug 38256] [GTK] Random failure on 'testdownload' unit test

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38256





--- Comment #15 from Mario Sanchez Prada <msanchez at igalia.com>  2010-05-13 01:22:48 PST ---
(In reply to comment #13)
> (From update of attachment 55275 [details])
> Seems the ChangeLog is hosed in the patch.

What do you mean?

> Also, can you explain there why are you doing what you do?

Well, as I said in comment #4:

"This second patch is related to the same issue because it could happen, with
the current code, that the set_filename () function got called too early in the
mainloop, therefore screwing the tests because the 'theDownload' global
variable wouldn't be properly set yet.

With this modification we ensure the set_filename() function gets called always
after handling the download-requested signal, therefore avoiding potential
problems."

So, the point is about making sure things happen in the right moment, instead of trusting the main loop to execute the idle function in the right time.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.