[Webkit-unassigned] [Bug 39043] Don't include RetainPtr.h unless PLATFORM(CF) is set

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39043


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55941|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2010-05-12 23:07:52 PST ---
(From update of attachment 55941)
>  #include <errno.h>
>  #include <stdio.h>
> +#if PLATFORM(CF)
>  #include <wtf/RetainPtr.h>
> +#endif
>  #include <wtf/Threading.h>
>  #include <wtf/Vector.h>
>  #include <wtf/text/CString.h>

Includes inside #if go in their own paragraph, not sorted in the middle of the main include paragraph.

We also normally put #if in headers so we don't have to make includes everywhere conditional. For example, see the #if ENABLE(SVG) in SVGElement.h. Despite those minor problems it seems OK to land this as-is.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.