[Webkit-unassigned] [Bug 25639] Spellcheck disabling does not disable context menu

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 12 21:38:23 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=25639





--- Comment #6 from Tony Chang (Google) <tony at chromium.org>  2010-05-12 21:38:22 PST ---
(In reply to comment #3)
> I wonder how other context menu items (cut/copy/paste/copy link address) are tested?

As far as I can tell, people test the behavior (e.g., the result of a paste), not the menu itself.

(In reply to comment #4)
> I don't think this is the right level to do this check; the check itself is OK but a bit too low level. If you look at the call site in ContextMenu::populate, it has some logic about menu items related to spelling that runs even if the function returns false.

I moved the check to ContextMenu.  I wasn't sure what to do about the "Spelling and Grammar" menu.  The current patch keeps it, but I think either behavior would be ok.  I didn't merge with the isInPasswordField because it's used for other things like disabling transformations.

This includes a layout test with an extension to eventSender.  Since it gets the context menu items, I'll have to grab results for Tiger and Snow Leopard from the bots.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list