[Webkit-unassigned] [Bug 38920] V8 overload support ported to JSC

Wed May 12 18:55:43 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=38920


--- Comment #6 from Yaar Schnitman <yaar at chromium.org>  2010-05-12 18:55:43 PST ---
(In reply to comment #5)
> It is possible I am reading this wrong, but where are the implementations of testObjPrototypeFunctionOverloadedMethod1Callback and friends.  
Nice catch. This slipped in from V8. I'll fix that. I would have probably caught that once I turned on some of the overloads in the IDLs.

> Can we optimize the if statement in this function so it does not do the same work multiple times (calling things like inherits)?
This can probably be done, but its very hard and with significant added complexity to the generator. In real use cases (WebGL, Canvas and XHR overloads), the primary determinant is the length of the args vector, and therefore only a small portion of the if statements are actually passed through. Also, in these overrides, the overhead of override selection is dwarfed by what these overrides usually do (e.g. copy large arrays). Therefore such an optimization won't have a big impact.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.