[Webkit-unassigned] [Bug 37945] CMake buildsystem

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37945





--- Comment #23 from Adam Treat <treat at kde.org>  2010-05-12 16:42:58 PST ---
(In reply to comment #22)
> (From update of attachment 55750 [details])
> > +IF (NOT WTF_USE_ICU_UNICODE)
> > +    ADD_DEFINITIONS(-DWTF_USE_ICU_UNICODE=0)
> 
> /home/manyoso/dev/webkit_1/JavaScriptCore/wtf/Platform.h:580:1: warning: "WTF_USE_ICU_UNICODE" redefined
> 
> This is in cross-platform wtf/CMakeLists.txt and in Platform.h you can see that you are re-defining it.
> 
> This needs to be fixed.

Ok, I've gone ahead and tried a full build, but my edje packages were not new enough.  Regardless, here is what I think needs to be fixed for review:

1) FindXXX.cmake packages for all required/optional dependencies.  I'd like to see this for both Efl specific dependencies as well as the generic cross-platform dependencies.

2) Need to be able to build without any of the optional packages. (See ICU error above)

3) Remove all port specific references from the cross-platform CMakeLists.txt... For example, I see that JavaScriptCore/wtf/CMakeLists.txt references the various ports to decide if it should include unicode.  This logic needs to be moved out as it is a recipe for spaghetti build code.  The port specific files should decide which unicode to include, etc.  Suggestions for mechanism for doing this would be helpful.  For instance, instead of the main CMakeLists.txt including Options{$PORT}... I'd rather it the other way around.  I'd rather the port specific build files including the cross-platform ones.

Those are the standout pieces (the last one might be a big change) so I'll leave it there for now.  Comments?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.