[Webkit-unassigned] [Bug 37945] CMake buildsystem

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37945





--- Comment #15 from Patrick R. Gansterer <paroga at paroga.com>  2010-05-12 12:34:30 PST ---
(In reply to comment #14)
> (In reply to comment #13)
> > Is there a reason for declaring the library names?
> > Why you use "${JavaScriptCore_LIBRARY_NAME}" instead of "JavaScriptCore" only?
> > 
> 
> Each port might want to define different names for these libraries. For instance, the EFL port creates a libewebkit.so under Unix; the GTK+ port might want to create a libwebkitgtk.so and so on.
Ok, makes sense! ;-)

> 
> > You have to dedect your libraries with a FindXXX.cmake first!
> 
> I know it is standard practice in CMake to use FindXXX, however the EFL platform is basically Unix-targeted, so we're using PKG_CHECK_MODULES() which uses pkg-config.
> 
> If it is absolutely needed, we may either use standard FindXXX and/or create ones that don't exist (such as the ones for the EFL libraries).
> 
> However, note that these checks are being performed inside the EFL Options file, so even pkg-config not existing or behaving weirdly in platforms other than Unix, it won't really be a portability issue.

I think it should be done via FindXXX.
Many of the 3rdparty libs like libxml, sqlite, ... are used on other ports too, so the FindXXX can be reused then.
Most of the FinXXX you'll need exist already.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.