[Webkit-unassigned] [Bug 38998] svn-apply failed to set reviewer correctly for attachment 55695

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38998





--- Comment #1 from Chris Jerdonek <cjerdonek at webkit.org>  2010-05-12 09:49:09 PST ---
It is a regression.  It is caused by the fact that the first diff (included below) is a ChangeLog and has leading junk containing the line "Reviewed by NOBODY (OOPS!)."  The setChangeLogDateAndReviewer() subroutine of svn-apply substitutes the reviewer only for the first occurrence.

We should probably make it so that the leading junk is not included in the patch contents sent to setChangeLogDateAndReviewer().  A quicker fix might be to have setChangeLogDateAndReviewer() replace all the occurrences and not just the first.

--------------
>From 25cc5eb85f766cafaa6ba715aa6cc62825ccdcc9 Mon Sep 17 00:00:00 2001
From: Rodrigo Belem <rodrigo.belem at openbossa.org>
Date: Tue, 11 May 2010 09:13:02 -0400
Subject: [PATCH] [Qt, Gtk] Allows build-webkit script to receive an install prefix as parameter
 https://bugs.webkit.org/show_bug.cgi?id=26224

Reviewed by NOBODY (OOPS!).

WebCore:

This patch adds the ability, in the QtWebkit build system, to change
the installation path.

* WebCore.pro:

WebKitTools:

Added more parameters to build-webkit script, the --prefix for gkt
and --install-libs, --install-headers for qt. Now it is possible
to change the install prefix for gtk and install path for qt.

* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
---
 WebCore/ChangeLog                 |   12 ++++++++++++
 WebCore/WebCore.pro               |   13 ++++++++++---
 WebKitTools/ChangeLog             |   14 ++++++++++++++
 WebKitTools/Scripts/build-webkit  |   15 ++++++++++++++-
 WebKitTools/Scripts/webkitdirs.pm |   19 +++++++++++++++----
 5 files changed, 65 insertions(+), 8 deletions(-)

Index: WebCore/ChangeLog
index eab24cc..b92c799 100644
--- WebCore/ChangeLog
+++ WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2010-05-10  Rodrigo Belem  <rodrigo.belem at openbossa.org>
+
+        Reviewed by NOBODY (OOPS!).
+
+        [Qt, Gtk] Allows build-webkit script to receive an install prefix as parameter
+        https://bugs.webkit.org/show_bug.cgi?id=26224
+
+        This patch adds the ability, in the QtWebkit build system, to change
+        the installation path.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.