[Webkit-unassigned] [Bug 38667] Web Inspector: add help on keyboard shortcuts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38667


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55834|review?                     |review+
               Flag|                            |




--- Comment #17 from Pavel Feldman <pfeldman at chromium.org>  2010-05-12 05:36:31 PST ---
(From update of attachment 55834)
r+ with comments, please fix prior to landing.

WebCore/inspector/front-end/ConsoleView.js:104
 +      var shortcut = WebInspector.KeyboardShortcut;
extract method?

WebCore/inspector/front-end/ElementsPanel.js:110
 +      var shortcut = WebInspector.KeyboardShortcut;
extract method + fill style shortcuts from here as well or call explicit method on styles sidebar.

WebCore/inspector/front-end/ScriptsPanel.js:178
 +      section.addAlternateKeys([ shortcut1.name, shortcut2.name ], "Continue");
consider extracting.

WebCore/inspector/front-end/ShortcutsHelp.js:101
 +      get height()
_ is private to a compilation unit, not a class.

WebCore/inspector/front-end/ShortcutsHelp.js:51
 +      this._helpScreen.show();
tab?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.