[Webkit-unassigned] [Bug 38665] [chromium] Update chromium port to send/receive cached metadata

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38665


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55596|review?                     |review-
               Flag|                            |




--- Comment #16 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-05-11 15:53:10 PST ---
(From update of attachment 55596)
WebKit/chromium/public/WebKitClient.h:196
 +      virtual void cacheMetadata(const WebURL&, long long, const char*, size_t) { }
please document the non-obvious parameters by giving them a name :-)

virtual void cacheMetadata(const WebURL&, long long responseTime, const char* data, size_t dataLength) { }

ordinarily, we use 'double' to represent timestamps in webkit.  is there a reason for using 'long long' instead of 'double'?  i realize that chromium uses long long.

WebKit/chromium/public/WebURLLoaderClient.h:60
 +      virtual void didReceiveCachedMetadata(WebURLLoader*, const char* data, int dataLength) { }
i presume it is promised that didReceiveCachedMetadata will not be called after didFinishLoading or didFail, right?

WebKit/chromium/public/WebURLResponse.h:75
 +      WEBKIT_API long long responseTime() const;
same comment about 'long long' versus 'double'

WebKit/chromium/src/ResourceHandle.cpp:176
 +  void ResourceHandleInternal::didReceiveCachedMetadata(
no line break here in webkit style

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.