[Webkit-unassigned] [Bug 38942] New: Improve build-webkit script to detect that FeatureDefines.xcconfig is not in sync

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 11 15:42:04 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38942

           Summary: Improve build-webkit script to detect that
                    FeatureDefines.xcconfig is not in sync
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jianli at chromium.org
                CC: eric at webkit.org, mrowe at apple.com, jianli at chromium.org


All instances of FeatureDefines.xcconfig need to sync up. Otherwise, the build could be broken. See comments from WebCore/Configuration/FeatureDefines.xcconfig.

// The contents of this file must be kept in sync with FeatureDefines.xcconfig in JavaScriptCore,
// WebCore and WebKit.  Also the default values of the ENABLE_FEATURE_NAME macros in build-webkit
// should match the values below, but they do not need to be in the same order.

To avoid this, we could write a script to compare those FeatureDefines.xcconfig and run it from build-webkit. This should make us detect the problem earlier.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list