[Webkit-unassigned] [Bug 38941] New: build-webkit shouldn’t override ENABLE_FOO Xcode configuration settings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38941

           Summary: build-webkit shouldn’t override ENABLE_FOO Xcode
                    configuration settings
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mrowe at apple.com


build-webkit always passes every ENABLE_FOO macro that it knows about through to xcodebuild.  This leads to the default values in FeatureDefines.xcconfig being ignored.  Since build-webkit is used solely by OpenSource-only builds this results in non-obvious problems:
1) Mismatched ENABLE_FOO settings across projects are not apparent.
2) Inconsistent default values between build-webkit and FeatureDefines.xcconfig results in world builds when switching between the different means of building.

build-webkit should only be passing ENABLE_FOO settings to xcodebuild if their values are explicitly being overridden.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.