[Webkit-unassigned] [Bug 38886] Add script to check for minimum python version and install if missing on Tiger

Tue May 11 13:35:15 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=38886

--- Comment #4 from Eric Seidel <eric at webkit.org>  2010-05-11 13:35:15 PST ---
(In reply to comment #3)
> > This will result in the disk image opening in the Finder and appearing in the sidebar.  hdiutil has a “-nobrowse” flag to prevent this.
> 
> Correct.  This was intentional.  If the script failed I didn't want to a random invisible mount around.  I'm happy to change it if you think it's better to hide the mount.

I've changed it to use -nobrowse in the latest version.  That makes it more difficult to debug if something goes wrong, but makes it quieter while operating.  Not a big deal either way.

> > Rather than doing this regexp hackery you could generate a mount point path yourself (somewhere under $TMPDIR?) and use hdiutil’s “-mountpoint” flag to arrange for it to be mounted there.
> 
> I considered that, however I didn't know how rm would fair trying to delete a mount point.  I guess I'll just have to test it.  The temp directory from File::Temp->createdir automatically deletes itself when perl exits.

rm won't delete the mountpoint.  So the temp directory deletion will fail if for some reason the script were to exit w/o unmounting the DMG.  However I changed the code to use a specific mount point per your suggestion.  I've tested it and it works fine.

I'll post a patch momentarily which I believe addresses all of your previous concerns.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.