[Webkit-unassigned] [Bug 34539] NP_VERSION_MINOR is not correct for some ports

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34539





--- Comment #23 from Anders Carlsson <andersca at apple.com>  2010-05-11 11:09:03 PST ---
(In reply to comment #22)
> (In reply to comment #21)
> > (From update of attachment 55694 [details] [details])
> > > +
> > > +// FIXME: This is added to work around build failure by the qt/gtk build boats.
> > > +// See comments # 11,14 & 15 of https://bugs.webkit.org/show_bug.cgi?id=34539.
> > > +#ifndef _INT32
> > > +#define _INT32
> > > +#ifdef __LP64__
> > > +typedef int int32;
> > > +typedef unsigned int uint32;
> > > +#else /* __LP64__ */
> > > +typedef long int32;
> > > +typedef unsigned long uint32;
> > > +#endif /* __LP64__ */
> > > +#endif
> > > +
> > > +
> > 
> > This is wrong. You should use the new C99 types instead, int32_t and uint32_t.
> > 
> > Marking r- for this reason.
> 
> It is not by choice... See the function declaration for NPN{Get/Set}ValueForURL in WebCore/bridge/npapi.h. Actually the redefinition here is not necessary if the build bots (both gtk and qt) did not fail. However, if this definition is wrong here, then it is also wrong the header file I mentioned above...

The function declaration here? 

http://trac.webkit.org/browser/trunk/WebCore/bridge/npapi.h#L768

This uses uint32_t.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.