[Webkit-unassigned] [Bug 38742] [chromium] Implement canEstablishDatabase call for workers.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 11 10:12:19 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38742





--- Comment #23 from Andrew Wilson <atwilson at chromium.org>  2010-05-11 10:12:18 PST ---
(In reply to comment #21)
> Dmitry stated in Comment #7 that this was not possible
I don't think that's correct. What he was saying is that you are never going to call this code outside of worker context, which I agree with. However, you could certainly call this code while the worker is shutting down, which will also cause controllerForContext() to return 0, I believe. Dmitry is indeed the authority here, but I'd like him to confirm that not checking for 0 is OK.

> 
> e.g. createApplicationCacheHost should not be called either, I'd rather add ASSERT_NOT_REACHED to all methods that should not be invoked (but I cannot judge which these are), or none.
> 
I understand your desire for consistency. If you want to change those other lines to be ASSERT_NOT_REACHED() also (and run the appropriate tests to make sure it doesn't break anything) I'm fine with that. The worker interface is confusing enough with various interfaces that are implemented but never called on certain sides of the renderer/worker divide, that I feel pretty strongly that we should be using ASSERT_NOT_REACHED() wherever possible, even if past authors haven't been rigorous in this regard.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list