[Webkit-unassigned] [Bug 34539] NP_VERSION_MINOR is not correct for some ports

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34539


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55694|review?                     |review-
               Flag|                            |




--- Comment #21 from Anders Carlsson <andersca at apple.com>  2010-05-11 09:53:40 PST ---
(From update of attachment 55694)
> +
> +// FIXME: This is added to work around build failure by the qt/gtk build boats.
> +// See comments # 11,14 & 15 of https://bugs.webkit.org/show_bug.cgi?id=34539.
> +#ifndef _INT32
> +#define _INT32
> +#ifdef __LP64__
> +typedef int int32;
> +typedef unsigned int uint32;
> +#else /* __LP64__ */
> +typedef long int32;
> +typedef unsigned long uint32;
> +#endif /* __LP64__ */
> +#endif
> +
> +

This is wrong. You should use the new C99 types instead, int32_t and uint32_t.

Marking r- for this reason.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.