[Webkit-unassigned] [Bug 38688] Support control attribute of HTMLLabelElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38688


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55650|review?                     |review+
               Flag|                            |




--- Comment #16 from Darin Adler <darin at apple.com>  2010-05-11 09:46:18 PST ---
(From update of attachment 55650)
> -HTMLElement* HTMLLabelElement::correspondingControl()
> +HTMLElement* HTMLLabelElement::control()

Why isn't the return type of this HTMLFormControlElement*? There are a lot of places in this patch that use HTMLElement* but instead should use HTMLFormControlElement.

> +        // Search the children and descendants of the label element for a form element.
> +        // per http://dev.w3.org/html5/spec/Overview.html#the-label-element
> +        // the form element must be "labelable form-associated element".

I think the comment should just leave out the link and say something more like this:

    // HTML5 says to search our descendants for the first labelable form-associated element
    // in document order.

OK as-is, though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.