[Webkit-unassigned] [Bug 38667] Web Inspector: add help on keyboard shortcuts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38667


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55699|review?                     |review-
               Flag|                            |




--- Comment #13 from Pavel Feldman <pfeldman at chromium.org>  2010-05-11 07:14:14 PST ---
(From update of attachment 55699)
Almost there...

WebCore/inspector/front-end/HelpScreen.js:1
 +  WebInspector.HelpScreen = function(sections, nColumns)
You need copyright here.

WebCore/inspector/front-end/HelpScreen.js:97
 +  WebInspector.shortcutsHelpSection = function(name)
It'd be great to have this on some singleton class corresponding to keyboard shortcuts screen. That class would also have methods for showing / hiding it.

WebCore/inspector/front-end/HelpScreen.js:105
 +  WebInspector.ShortcutsSection = function(name)
You want this in a separate file (ShortcutsScreen.js probably).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.