[Webkit-unassigned] [Bug 38853] [GTK] Double clicks cause three button press events

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 10 20:52:37 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38853





--- Comment #9 from Martin Robinson <mrobinson at webkit.org>  2010-05-10 20:52:37 PST ---
(In reply to comment #4)
> Could the patch be divided like:
>   - Refactoring, these changes look nice: prepareMouseButtonEvent, sendOrQueueEvent, 
>   - Fix click problems

Thanks for the review!

I've split the patch into two:
1. One to add rudimentary leapForward support which includes the initialization fix.
2. Another which includes the style fixes and add prepareMouseButtonEvent.

>   - leapForward support, why is this required? Could you just leave the main loop iterate as usual? 
> 
> +            while (!doneLeapingForward)
> +                gtk_main_iteration();
> 

I think you're right here. I've reworked the logic a bit. It's simpler now, because we don't need a lot of the drag-and-drop stuff yet (perhaps until we add dropping support to the DRT and perhaps never).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list