[Webkit-unassigned] [Bug 38870] svn.webkit.org needs a post-commit hook to fix svn:author from commit-queue patches

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38870





--- Comment #11 from Eric Seidel <eric at webkit.org>  2010-05-10 16:45:33 PST ---
(In reply to comment #7)
> This is more of a first draft for discussion.  Open questions:

Thank you!

> 1) Should we only change the svn:author for the commit-queue?

Yes.  Otherwise you could "commit as" darin just by putting his name in the ChangeLog.  Eeek.
Ideally we should create a separate commit account for the commit-queue. :)

> 2) How does this code handle the case where we have a users bugzilla email in committers.py but not their svn email?

I don't think we should use the committers.py list.  It's nice, but it's not as accurate as the theoretical svn auth file on the server (which I know nothing about).

> 3) Can post-commit call this script directly or do we need a shell script in between?

I don't see why not.

> 4) What's our testing plan here?

If we're using webkitpy, we should be able to write python unit tests for testing what happens with various ChangeLog messages.  scm_unittests or checkout_unittests would be appropriate places.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.