[Webkit-unassigned] [Bug 34539] NP_VERSION_MINOR is not correct for some ports
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 10 16:13:51 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=34539
--- Comment #13 from WebKit Review Bot <webkit.review.bot at gmail.com> 2010-05-10 16:13:50 PST ---
Attachment 55617 did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/plugins/npapi.cpp:28: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebCore/plugins/npapi.cpp:188: NPN_GetValueForURL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/plugins/npapi.cpp:226: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
WebCore/plugins/npapi.cpp:241: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
WebCore/plugins/npapi.cpp:266: NPN_SetValueForURL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/plugins/npapi.cpp:270: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
WebCore/plugins/npapi.cpp:295: NPN_GetAuthenticationInfo is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/plugins/npapi.cpp:300: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
Total errors found: 8 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list