[Webkit-unassigned] [Bug 38861] new-run-webkit-tests fails when run under sys.platform == "windows" due to undefined signal.SIGKILL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38861


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |maruel at chromium.org




--- Comment #3 from Eric Seidel <eric at webkit.org>  2010-05-10 12:43:35 PST ---
Traceback (most recent call last):
 File "C:\b\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\new-run-webkit-tests",
line 33, in <module>
   import webkitpy.layout_tests.run_webkit_tests as run_webkit_tests
 File "C:\b\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py",
line 77, in <module>
   from webkitpy.common.system.executive import Executive
 File "C:\b\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\common\system\executive.py",
line 93, in <module>
   class Executive(object):
 File "C:\b\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\common\system\executive.py",
line 174, in Executive
   _KILL_PROCESS_KILLED_PROCESS_EXIT_CODE = 0 if sys.platform ==
"windows" else -signal.SIGKILL
AttributeError: 'module' object has no attribute 'SIGKILL'

Was the exception.

I've not tested this code on sys.platform == "windows" as I don't currently have such a setup.  We need to get the chromium canary bots to run test-webkitpy.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.