[Webkit-unassigned] [Bug 38630] VS2010 asserts a null iterator passed to std::copy in Vector::operator=

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38630


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55545|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #11 from Alexey Proskuryakov <ap at webkit.org>  2010-05-10 09:52:05 PST ---
(From update of attachment 55545)
> The standard says neither "The OutputIterator parameter must be dereferenceable"
> nor "It may be not dereferenceable if [first, last) is empty."  So we can't
> assume the VS2010 behavior is a bug.

The standard doesn't need to explicitly mention everything it allows. If there is no restriction, then it's allowed.

Please make this fix only for MSVC2010, file a bug with them, and reference this bug in a comment in code, so that we could know when to remove the workaround.

-        if (size() > other.size())
+        if (size() > other.size()) {
             shrink(other.size());
-        else if (other.size() > capacity()) {
+            return *this;
+        }

This doesn't look like it could possibly work. Did you run regression tests with this patch? Or am I just confused?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.