[Webkit-unassigned] [Bug 38213] Page up / page down moves edited content for the entire height

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38213





--- Comment #23 from Tony Chang (Google) <tony at chromium.org>  2010-05-09 17:50:56 PST ---
(In reply to comment #21)
> (From update of attachment 55433 [details])
> WebCore/editing/EditorCommand.cpp:260
>  +      if (!(style->overflowY() == OSCROLL || style->overflowY() == OAUTO || focusedNode->isContentEditable()))
> This is only tangentially related to your code, so feel free to ignore, but this if-statement doesn't look right to me. If we're in a contentEditable element that's overflow:visible, I think we probably want to early return here.

This is correct.  I added it to fix the bug where we weren't moving the cursor in contentEditable.  The code reads: if the node is not contentEditable, then don't move the cursor (i.e., move the cursor 0 lines).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.