[Webkit-unassigned] [Bug 38812] Clean up: Extract regular expressions for parsing the start of an SVN and Git header into functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38812





--- Comment #4 from Daniel Bates <dbates at webkit.org>  2010-05-09 02:41:05 PST ---
(In reply to comment #3)
> (From update of attachment 55495 [details])
> > +++ WebKitTools/ChangeLog	(working copy)
> > +        Extract the regular expressions for parsing the start of an SVN and
> > +        Git header into their own respective functions so as to centralize
> > +        these regular expressions as they are used throughout VCSUtils.pm.
> 
> As we discussed, this needs to be updated.

Will change.

> 
> > +++ WebKitTools/Scripts/VCSUtils.pm	(working copy)
> > +my $gitHeaderStartRegEx = qr#^diff --git (\w/)?(.+) (\w/)?([^\r\n]+)#;
> > +my $svnHeaderStartRegEx = qr#^Index: ([^\r\n]+)#;
> 
> Might it be more straightforward to call these gitDiffStartRegEx and svnDiffStartRegEx?

Will change.

> 
> It's probably best to re-post after this since the latter involves a bunch of changes.

Will repost with changes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.