[Webkit-unassigned] [Bug 38683] SVG FilterEffects need more detailed DRT information

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38683





--- Comment #13 from Dirk Schulze <krit at webkit.org>  2010-05-09 02:07:48 PST ---
(In reply to comment #12)
> LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:14
>  +              [feColorMatrix type="MATRIX" values="0.33 0.33 0.33 0.00 0.00 0.33 0.33 0.33 0.00 0.00 0.33 0.33 0.33 0.00 0.00 0.33 0.33 0.33 0.00 0.00 "]
> Here's a trailing space in feColorMatrix value dumping that should be removed.
We don't know the count of values that's why I took number << " ", spaces wouldn't go away for " " << number.

> 
> LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:13
>  +              [feImage image-size="150x150"]
> Why not rename it to size? feImage image-size looks odd.
If we later dump the subRegion, it should be more clear about what size we are  talking. There are much more sizes we could dump.

> 
> LayoutTests/platform/mac/svg/batik/filters/filterRegions-expected.txt:26
>  +          [feFlood flood-color="#FF0000" flood-opacity="1.00"]
> feFlood flood-color/opacity, same issue. maybe just dump color & oapcity here.
The attributes are called that way. I fear, that someone mixes it up with the color or opacity property, they are _not_ the same, and we should name them different.

> 
> Just small issues remaining, the patch looks great as well as the results!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.