[Webkit-unassigned] [Bug 38718] test-webkitpy fails under cygwin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38718


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aroben at apple.com




--- Comment #27 from Ojan Vafai <ojan at chromium.org>  2010-05-08 07:30:47 PST ---
> > WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_win.py:60
> >  +          # FIMXE: This should include mac-snowleopard like win.py does.
> > No, I don't think it should, although it probably shouldn't fall back to win or
> > mac at all, really. We should check to see if those directories are actually
> > used.
> 
> I leave you and Ojan to duke it out.  I'm happy to keep or remove the FIXME. 
> I'll land it either way and someone later can fix/remove.

chromium-win and webkit-win should use the same fallback directories. Hopefully
we agree on that. :) It's confusing to me that webkit-win checks the
mac-snowleopard directory, but given that it does, chromium-win should as well.

A change needs to be made to either chromium-win or webkit-win.

aroben, you have an opinion about the appropriate fallback directories for
windows?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.