[Webkit-unassigned] [Bug 38663] SVGFont's VKern implementation missing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 8 01:18:53 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38663





--- Comment #7 from Dirk Schulze <krit at webkit.org>  2010-05-08 01:18:52 PST ---
(In reply to comment #6)
> Attachment 55465 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']"
> exit_code: 1
> WebCore/rendering/SVGRootInlineBox.cpp:365:  Tests for true/false,
> null/non-null, and zero/non-zero should all be done without equality
> comparisons.  [readability/comparison_to_zero] [5]
> Total errors found: 1 in 35 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

The != 0 check is needed here, since the results are allowed to be negative.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list