[Webkit-unassigned] [Bug 37515] getPathSegAtLength() gives incorrect value

Sat May 8 00:53:20 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=37515

Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55468|review?                     |review-
               Flag|                            |

--- Comment #11 from Nikolas Zimmermann <zimmermann at kde.org>  2010-05-08 00:53:20 PST ---
(From update of attachment 55468)
WebCore/svg/SVGPathSegList.cpp:103
 +      return --traversalState.m_segmentIndex;
Hm, why is that? Just return "traversalState.m_segmentIndex - 1". That saves
one assignment operation :-)
Sorry for that, but r- :( Other than that it looks very good, If you change
that last thing, I'm going to set r+/cq+

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.