[Webkit-unassigned] [Bug 38718] test-webkitpy fails under cygwin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38718





--- Comment #21 from Dirk Pranke <dpranke at chromium.org>  2010-05-07 19:56:48 PST ---
(In reply to comment #20)
> (In reply to comment #19)
> > (From update of attachment 55447 [details] [details])
> > WebKitTools/Scripts/webkitpy/common/system/executive.py:184
> >  +              command = ["taskkill.exe", "/f", "/pid", pid]
> > This comment seems to conflict with the code 
> 
> I assume you mean this comment?
>         if sys.platform == "windows":
>             # We can't (easily) use taskkill.exe on cygwin because
>             # subprocess.pid is a cygwin pid and taskkill expects a windows
> pid.
>             # Thankfully os.kill on cygwin handles either pid type.
> 
> I was trying to explain why that wasn't "sys.platform in ("windows", "cygwin")"
> like how kill_all is done.
> 

Yeah, I was confused by the fact that "windows" and "cygwin" are not the same
thing and was thinking that you meant to be calling os.kill() instead of
taskkill.exe. Maybe there's some way you can' rewrite this to say something
like "we can only use taskkill.exe on windows and not cygwin", to make it clear
that you're talking about the branch you took, and not the branch you didn't
take.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.