[Webkit-unassigned] [Bug 38718] test-webkitpy fails under cygwin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38718


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |levin at chromium.org




--- Comment #20 from Eric Seidel <eric at webkit.org>  2010-05-07 19:22:09 PST ---
(In reply to comment #19)
> (From update of attachment 55447 [details])
> WebKitTools/Scripts/webkitpy/common/system/executive.py:184
>  +              command = ["taskkill.exe", "/f", "/pid", pid]
> This comment seems to conflict with the code 

I assume you mean this comment?
        if sys.platform == "windows":
            # We can't (easily) use taskkill.exe on cygwin because
            # subprocess.pid is a cygwin pid and taskkill expects a windows
pid.
            # Thankfully os.kill on cygwin handles either pid type.

I was trying to explain why that wasn't "sys.platform in ("windows", "cygwin")"
like how kill_all is done.

> WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_win.py:60
>  +          # FIMXE: This should include mac-snowleopard like win.py does.
> No, I don't think it should, although it probably shouldn't fall back to win or
> mac at all, really. We should check to see if those directories are actually
> used.

I leave you and Ojan to duke it out.  I'm happy to keep or remove the FIXME. 
I'll land it either way and someone later can fix/remove.

@abarth, @davelevin or @cjerdonek: care to review?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.