[Webkit-unassigned] [Bug 38692] rebaseline-chromium-webkit-tests crashes if nothing is built

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38692


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55449|review?                     |review+
               Flag|                            |




--- Comment #8 from Eric Seidel <eric at webkit.org>  2010-05-07 19:18:16 PST ---
(From update of attachment 55449)
I dislike the way we do the testing for the existance of the image_diff binary.
 However, you've not changed the previous code, and it's now tested, so this
patch is a huge win! :)

I think that the design error here is that configuration is a property of a
port.  It's information provided to a port, but it is not itself a property of
said port.  Since it is, it makes use create a port just to test a
configuration.  Waht we really want to do is have some port instance which we
can then ask questions pertaining to a configuration, and then store that
configuration either in the port or separate.

Thanks for all the hard work!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.