[Webkit-unassigned] [Bug 38742] [chromium] Implement canEstablishDatabase call for workers.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38742


Michael Nordman <michaeln at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaeln at google.com




--- Comment #8 from Michael Nordman <michaeln at google.com>  2010-05-07 12:09:02 PST ---
This looks pretty good to me.

Consider setting the result data member and done data member in the
AllowDatabaseMainThreadBridge::didComplete() method body which is run on the
context thread. That could help get rid of the mutex.

 91     // Controls whether access to Web Databases is allowed for this worker.
 92     virtual bool allowDatabase(WebFrame*, const WebString& name, const
WebString& displayName, unsigned long estimatedSize);

Does WebWorkerBase::allowDatabase really need to be virtual? I don't think this
is an overload of the method in the public api. Also I think the method
arguments can be in terms of WebCore types instead of WebKit types.

Is WebWorkerClientImpl::allowDatabase really needed? When/where is that method
called?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.