[Webkit-unassigned] [Bug 37798] svg/custom/use-instanceRoot-as-event-target.xhtml crashes randomly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37798





--- Comment #8 from Nikolas Zimmermann <zimmermann at kde.org>  2010-05-07 10:52:39 PST ---
(In reply to comment #7)
> (From update of attachment 55368 [details])
> WebCore/ChangeLog:14
>  +          it, but residing in the correspondingElement() event listener list
> (and thus existant!).
> The last sentence isn't entirely english.  registrated and existant aren't
> words.
Fixed.

> WebCore/svg/SVGElementInstance.cpp:92
>  +      if (!element || !element->document())
> I can never remember if this is the right ->document() pointer or
> ownerDocument().  Should this be element->inDocument()?
I used || !element->inDocument(). Didn't know about this shortcut even.

> 
> WebCore/svg/SVGElementInstance.cpp:150
>  +      ASSERT_NOT_REACHED();
> Seems we should add comments in teh code to explain *why* these are
> ASSERT_NOT_REACHED()
Done.

> 
> LayoutTests/ChangeLog:8
>  +          Make use-instanceRoot-as-event-target.xhtml behave more correctly.
> Due a copy&paste problem test #7 was not executed. Fixed.
> copy & paste
Done.

> 
> Seems we need TestObject.idl changes to correspond with your codegenerator
> changes.
No this only affects SVGElementInstance.idl generation, nothing else.

Going to upload a new patch...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.