[Webkit-unassigned] [Bug 38753] Web Inspector: Autocompletion in console is not usable because it is not add to the entered text the common prefix of suggestions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38753


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55378|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #3 from Timothy Hatcher <timothy at hatcher.name>  2010-05-07 09:18:47 PST ---
(From update of attachment 55378)
WebCore/inspector/front-end/TextPrompt.js:234
 +                      for (var j = wordPrefixLength; j < lastIndex; ++j)
Need {} around the body, since it is multiline (per style guide.)

WebCore/inspector/front-end/TextPrompt.js:248
 +                      for (var i = 0; i < completions.length; ++i)
Need {} around the body, since it is multiline (per style guide.)


WebCore/inspector/front-end/TextPrompt.js:235
 +                          if (commonPrefix[j] != completion[j]) {
!==

WebCore/inspector/front-end/TextPrompt.js:236
 +                              commonPrefix = commonPrefix.substr(0,j);
Add a space after ",".

Otherwise looks great! Thanks for the screencast.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.