[Webkit-unassigned] [Bug 34005] Safari pegs CPU and drops tons of frames using HTML5 Vimeo player

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34005


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55149|review?                     |review+
               Flag|                            |




--- Comment #70 from Eric Carlson <eric.carlson at apple.com>  2010-05-07 08:58:30 PST ---
(From update of attachment 55149)
>              if (shouldRestorePlaybackState && m_timeToRestore != -1.0f) {
>                  m_movieWin->setCurrentTime(m_timeToRestore);
> @@ -281,7 +190,7 @@ void QTMovieWinPrivate::task()
>                  m_rateToRestore = -1.0f;
>              }

I know you didn't add this, but as long as you are cleaning things up you might
as well change "-1.0f" to "-1" to match style guidelines.


> +    size_t indexOfClient = m_private->m_clients.find(client);
> +    if (indexOfClient >= 0)
> +        m_private->m_clients.remove(indexOfClient);

Is ever this OK for this search to fail? If not, add an ASSERT() so we can
track down the source of the problem.

Nice refactoring!

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.