[Webkit-unassigned] [Bug 38749] [Chromium] Pipe RTL info into WebPopupMenuInfo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 7 08:04:23 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38749





--- Comment #2 from Jeremy Moskovich <playmobil at google.com>  2010-05-07 08:04:23 PST ---
(From update of attachment 55374)
Ob-Disclaimer: I'm not a WebKit reviewer.

WebKit/chromium/src/ChromeClientImpl.cpp:694
 +      info->rightAligned = popupClient->menuStyle().textDirection() == RTL;
It's not really text alignment, but directionality - IMHO rename to rtl,
directionality [and use an enum] or somesuch.

Otherwise, lgtm.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list