[Webkit-unassigned] [Bug 38648] Ensure DRT loads GAIL (Gtk+ module), for a11y tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38648


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55267|0                           |1
        is obsolete|                            |
  Attachment #55354|                            |review?
               Flag|                            |




--- Comment #6 from Mario Sanchez Prada <msanchez at igalia.com>  2010-05-07 03:09:29 PST ---
Created an attachment (id=55354)
 --> (https://bugs.webkit.org/attachment.cgi?id=55354)
Patch to fix this issue

According to comment #5 I've been spending some time to find out why DRT is ran
without considering the GTK_MODULES envvar (if already set) and I found the
reason:

In WebKitTools/Scripts/old-run-webkit-tests > openDumpTool() a clean
environment is prepared before calling to DRT, which basically creates a
hashtable with the strictly needed envvars and nothing else, and that obviously
doesn't include GTK_MODULES at this point.

So, I think the current patch properly addresses the problem by just setting
the GTK_MODULES envvar to "gail" when running the tests for the Gtk port, as
that would be a clear requirement for the a11y tests to run ok under that
scenario.

Wrt the doubts also commented with xan about whether to append 'gail' to the
already present (if so) GTK_MODULES instead of just *setting* it to a specific
value, I'd say that the right thing to do in this case is just to set it, since
we don't want to put in that clean environment anything else but the strictly
needed things, which in this case means (at least afaik) to load Gail as the
only Gtk module.

Hope this patch looks better :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.