[Webkit-unassigned] [Bug 34005] Safari pegs CPU and drops tons of frames using HTML5 Vimeo player

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34005


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55056|review?                     |review+
               Flag|                            |




--- Comment #68 from Eric Carlson <eric.carlson at apple.com>  2010-05-06 22:47:29 PST ---
(From update of attachment 55056)

> +void MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage()
> +{
> +    if (!m_visualContext)
> +        return;
> +
> +    if (!m_qtVideoLayer)
> +        return;
> +
> +    QTPixelBuffer buffer = m_visualContext->imageForTime(0);
> +    if (!buffer.pixelBufferRef())
> +        return;
> +
I assume imageForTime(0) gets the image for "now"? I realize that it just 
wraps QTVisualContextCopyImageForTime and that functions defines the magic
value, but it would be nice
to define a constant instead of passing "0" - "kCurrentMovieTime" maybe ?


> +
> +        CFTimeInterval imageTime = QTMovieVisualContext::currentHostTime();
> +
"imageTime" isn't used anywhere, left over from earlier revision?

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.