[Webkit-unassigned] [Bug 38158] Fix gcc compiler warnings in chromium platform graphics code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38158


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55311|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #12 from Eric Seidel <eric at webkit.org>  2010-05-06 15:45:17 PST ---
(From update of attachment 55311)
 +      if (!((format == GraphicsContext3D::RGBA && type ==
GraphicsContext3D::UNSIGNED_BYTE) || (format == m_implementationColorReadFormat
&& type == m_implementationColorReadType))) {
As far as I can tell this is correct.  Certainly reads nicer.  I would probably
have even used local variables if I had written this originally. :)  GCC
warnings FTW.

WebCore/platform/graphics/chromium/FontLinux.cpp:608
 +          if (x >= 0 && x < walker.width()) {
I'm curious how, if at all, this changes behavior.  Is this testable?

Please add at least a ChangeLog comment explaining why the x >= does not change
behavior and does not require testing.  Otherwise this looks good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.