[Webkit-unassigned] [Bug 38594] Change IndexedDB to use events instead of callbacks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38594


Nate Chapin <japhet at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55258|review?                     |review+
               Flag|                            |




--- Comment #8 from Nate Chapin <japhet at chromium.org>  2010-05-06 14:56:28 PST ---
(From update of attachment 55258)
Your WebCore/ChangeLog diff is pretty far out of date in terms of the files
listed. Plus a couple of nits inline.

Besides that, LGTM.

> --- a/WebCore/bindings/js/JSEventCustom.cpp
> +++ b/WebCore/bindings/js/JSEventCustom.cpp
> @@ -38,6 +38,7 @@
>  #include "JSCustomEvent.h"
>  #include "JSCompositionEvent.h"
>  #include "JSErrorEvent.h"
> +#include "JSIDBRequest.h"
>  #include "JSKeyboardEvent.h"
>  #include "JSMessageEvent.h"
>  #include "JSMouseEvent.h"

Why is this necessary?

> +    ASSERT(0);
> +    return jsUndefined();
> +}

Nit (here and in V8IDBRequestCustom.cpp): Any reason not to use
ASSERT_NOT_REACHED instead?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.