[Webkit-unassigned] [Bug 37874] Provide mechanism to cache metadata for a resource

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37874


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55255|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #22 from Adam Barth <abarth at webkit.org>  2010-05-06 11:16:54 PST ---
(From update of attachment 55255)
Looks good.  Thanks for iterating on this patch.  Please address the minor nits
below before committing.  If you'd like the commit bot to land your patch, you
can upload a new patch with these comments addressed.

WebCore/loader/CachedMetadata.h:66
 +          return new CachedMetadata(dataTypeID, data, size);
adoptRef?

WebCore/loader/CachedMetadata.h:71
 +          return new CachedMetadata(data, size);
adoptRef?

WebCore/loader/CachedMetadata.h:62
 +      friend class CachedResource;
You can just make these methods public.  WebKit isn't super tight about hiding
interfaces.

WebCore/loader/ResourceLoader.h:101
 +          virtual void didReceiveCachedMetadata(ResourceHandle*, const char*
data, int length) { didReceiveCachedMetadata(data, length); }
These methods don't seem to fit the pattern of the other methods.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.