[Webkit-unassigned] [Bug 38557] r58526 introduced a ~30% regression on Dromaeo JS lib

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38557





--- Comment #4 from anton muhin <antonm at chromium.org>  2010-05-06 09:45:21 PST ---
(In reply to comment #3)
> Hi Anton,
> 
> I'm fairly snowed under myself this week, so Sam Weinig has kindly offered to
> step in for me and try to help.  I think he plans to start with the basics,
> take some shark profiles & see what shows up.  I'm sure he'll let you know once
> he has any info.
> 
> many thanks,
> G.

Sure, Gavin.

So the main suspect is GC for now: http://dromaeo.com/?id=102562,102570,102580
. First one is head of WebKit, the second one is head of WebKit with my change
backed out, the last one is head of WebKit with the following change:

$ git diff
diff --git a/WebCore/bindings/js/JSNodeCustom.cpp
b/WebCore/bindings/js/JSNodeCu
index 6d61037..c2ff970 100644
--- a/WebCore/bindings/js/JSNodeCustom.cpp
+++ b/WebCore/bindings/js/JSNodeCustom.cpp
@@ -179,7 +179,7 @@ void JSNode::markChildren(MarkStack& markStack)

     Node* node = m_impl.get();
     node->markJSEventListeners(markStack);
-    node->markCachedNodeLists(markStack, *Heap::heap(this)->globalData());
+    // node->markCachedNodeLists(markStack, *Heap::heap(this)->globalData());

     // Nodes in the document are kept alive by JSDocument::mark, so, if we're
i
     // the document, we need to mark the document, but we don't need to
explici

That's on windows box, but I hope to repro it on MBP as well.  Looking further.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.