[Webkit-unassigned] [Bug 21472] escaped characters cause parse errors in idents (for example in @namespace rules)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21472





--- Comment #9 from Daniel Glazman <daniel at glazman.org>  2010-05-06 08:45:20 PST ---
(In reply to comment #6)

> (From update of attachment 55223 [details])
> This patch has tabs in it. Please make a new one without tabs.
> 
> How did you test the effect of this change on CSS parsing performance? What was
> the effect?

I did not. This is my very first patch in the WebKit world and I'm not yet
familiar with the environment (10 years of mozillianism is barely an excuse;-)

I agree the proposed fix could be a wrong thing to do on a perf basis. But
the diagnosis of the bug is at least the right one. There are two issues here:

  - escaped chars in tokens
  - WebCore::CSSParser::text assuming a fixed length for functional notations

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.