[Webkit-unassigned] [Bug 38537] [Qt] Failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arc.angle.3.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38537





--- Comment #8 from qi <qi.2.zhang at nokia.com>  2010-05-06 06:31:11 PST ---
(In reply to comment #7)
> Seems we should import philip's tests into LayoutTests.  I'm cetain we already
> have a bugs.webkit.org bug about doing just that.

Eric, What's your means about "I'm cetain we already have a bugs.webkit.org bug
about doing just that."? Is that Laszlo talked Bug 38526? 

Actually in this patch I try to fix 3 issues. Just because they are all in one
function, so I make one patch. Bug 38526 is one of the 3 issues. 

Actually, I think Bug 38526 fix is not correct. 

Based on HTML5 spec:

The arc(x, y, radius, startAngle, endAngle, anticlockwise) method draws an arc.
If the context has any
subpaths, then the method must add a straight line from the last point in the
subpath to the start point of the arc.

Basically, if there are some elements before the arc, we need add a line from
that point to the arc start point, otherwise we don’t.

Currently, we always add a line to the arc, even there is no element before the
arc, by default it will add a line from (0,0) to the arc, that's wrong. See my
change.

I want to know what I need to do. This patch is not need any more? or I need to
create a layout test for it? or else..

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.