[Webkit-unassigned] [Bug 38633] [WTFURL] Add Chromium front-end to the URL parser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38633


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-05-06 01:54:06 PST ---
Attachment 55218 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']"
exit_code: 1
Last 3072 characters of output:
romium/parser.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
JavaScriptCore/wtf/url/chromium/parser.h:57:  spec_len is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/url/chromium/parser.h:58:  spec_len is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/url/chromium/parser.h:64:  spec_len is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/url/chromium/parser.h:65:  spec_len is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/url/chromium/parser.h:69:  spec_len is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/url/chromium/parser.h:70:  spec_len is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/url/chromium/parser.h:73:  spec_len is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/url/chromium/parser.h:74:  spec_len is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/url/chromium/parser.h:98:  spec_len is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/url/chromium/parser.h:99:  spec_len is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/url/chromium/parser.h:112:  port_num is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/url/chromium/parser.h:118:  port_num is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/url/chromium/parser.h:141:  file_name is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/url/chromium/parser.h:144:  file_name is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/url/chromium/parser.h:192:  spec_len is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/url/chromium/parser.h:193:  after_scheme is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
JavaScriptCore/wtf/url/chromium/parser.h:196:  spec_len is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/url/chromium/parser.h:197:  after_scheme is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
JavaScriptCore/wtf/url/chromium/parser.h:200:  One space before end of line
comments  [whitespace/comments] [5]
JavaScriptCore/wtf/url/chromium/parser.h:202:  One space before end of line
comments  [whitespace/comments] [5]
Total errors found: 22 in 3 files


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.