[Webkit-unassigned] [Bug 38034] WebSocket: pywebsocket 0.5

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38034





--- Comment #7 from Fumitoshi Ukai <ukai at chromium.org>  2010-05-05 23:26:50 PST ---
Thanks for review!

(In reply to comment #5)

> "Ditto." works instead of repeating the exact same comment.

Ok. Fixed.

> btw, can we just get rid of "run-webkit-websocketserver" and rename
> "new-run-webkit-websocketserver" to "run-webkit-websocketserver"? *Not in this
> patch* but a follow up patch.

Hmm, usage is a bit different (run-webkit-websocketserver runs until ENTER is
hit, new-run-webkit-websocketserver controls websocket server by --server=start
and --server=stop), but I think we could get rid of "run-webkit-websocketsever"
and make "new-run-webkit-websocketserver" to be "run-webkit-websocketserver".


> 
> > diff --git a/WebKitTools/Scripts/old-run-webkit-tests b/WebKitTools/Scripts/old-run-webkit-tests
> 
> The following lines are repeated in "closeWebSocketServer" It feels like it
> should be a common function that both of these places call.

I think we can simply use system here, instead of open3.

> > diff --git a/WebKitTools/Scripts/run-webkit-websocketserver b/WebKitTools/Scripts/run-webkit-websocketserver
> 
> This has the same problem of repeating a bunch of lines related to running
> webSocketServer

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.