[Webkit-unassigned] [Bug 38151] drop support for sessionStorage in sandbox iframes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38151


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55170|review?                     |review+
               Flag|                            |




--- Comment #11 from Eric Seidel <eric at webkit.org>  2010-05-05 22:28:14 PST ---
(From update of attachment 55170)
WebCore/storage/StorageEventDispatcher.cpp:60
 +              if (!ec)
Could/should this be an early return instead of further indent to the
line-that-never-wrapped?

WebCore/storage/StorageEventDispatcher.cpp:61
 +                 
frames[i]->document()->enqueueEvent(StorageEvent::create(eventNames().storageEvent,
key, oldValue, newValue, sourceFrame->document()->url(), storage));
I'm rather anti-wrap, but I think even I might have used a local variable here.

WebKit/chromium/src/StorageAreaProxy.cpp:130
 +              Storage* storage = frames[i]->domWindow()->sessionStorage(ec);
Why not just check storage != NULL?

Seems OK, even if the EC handling is slightly inelegant.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.